Allow command plugin to take a dir as input #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The command plugin requires proto files to be passed as separate inputs. While expanding these with a wildcard is straightforward, doing so usually requires the user to also set an import path. Modifications: - Allow directories to be used as input to the command plugin. Doing so also uses the directory as an import path. - Improve the help text for the command plugin and provide example calls Result: Easier to use the command plugin. In many cases users will only need to specify the directory containing their protos and the output directory.
gjcairo
approved these changes
Jul 25, 2025
glbrntt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The command plugin requires proto files to be passed as separate inputs. While expanding these with a wildcard is straightforward, doing so usually requires the user to also set an import path.
Modifications:
Result:
Easier to use the command plugin. In many cases users will only need to specify the directory containing their protos and the output directory.